chore(netxlite): isolate and annotate quirky functions #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a bunch of quirks in the codebase that are there because the ./legacy/netx package assumes them. So, in light of the fact that I'm going to modify how we construct HTTP clients, I feel a bit safer if we move what I should not touch in a different place. Part of ooni/probe#2531
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff isolates and annotates netxlite quirky functions such that ooni/probe#2534 will be easier. This work is also useful to ooni/probe#2531. While there, commit workaround for issue ooni/probe#2535.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff isolates and annotates netxlite quirky functions such that ooni/probe#2534 will be easier.
This work is also useful to ooni/probe#2531.
While there, commit workaround for issue ooni/probe#2535.