Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netxlite: windows: not the error we expected dns_nxdomain_error #2535

Open
bassosimone opened this issue Sep 14, 2023 · 0 comments
Open

netxlite: windows: not the error we expected dns_nxdomain_error #2535

bassosimone opened this issue Sep 14, 2023 · 0 comments
Assignees
@bassosimone
Labels
bug Something isn't working needs investigation This issue needs extra data and investigation ooni/probe-engine platform/windows priority/low testing

Comments

@bassosimone
Copy link
Contributor

Netxlite integration tests often times fail with this error. There is a note in the code explaining that we previously already had issues with this getaddrinfo-specific integration test and we implemented a workaround. We should figure out a better way of testing this functionality under Windows. In the meanwhile, I am going to skip this test on failure on Windows.
@bassosimone bassosimone added bug Something isn't working testing priority/low platform/windows needs investigation This issue needs extra data and investigation ooni/probe-engine labels Sep 14, 2023
@bassosimone bassosimone self-assigned this Sep 14, 2023
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 14, 2023
@bassosimone
workaround for ooni/probe#2535
20526b7
@bassosimone bassosimone mentioned this issue Sep 14, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Sep 14, 2023
@bassosimone
chore(netxlite): isolate and annotate quirky functions (#1269)
0f6b122 
This diff isolates and annotates netxlite quirky functions such that
ooni/probe#2534 will be easier.

This work is also useful to ooni/probe#2531.

While there, commit workaround for issue
ooni/probe#2535.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
chore(netxlite): isolate and annotate quirky functions (ooni#1269)
263b486 
This diff isolates and annotates netxlite quirky functions such that
ooni/probe#2534 will be easier.

This work is also useful to ooni/probe#2531.

While there, commit workaround for issue
ooni/probe#2535.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
bug Something isn't working needs investigation This issue needs extra data and investigation ooni/probe-engine platform/windows priority/low testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bassosimone