fix(enginenetx): pass context to tactics callbacks #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff modifies the tactics callbacks to take in input a context. We need the context to know whether the operation failed in itself or was canceled externally through the context. With this information, we can store better statistics about which tactics are working and which tactics are not working. Part of ooni/probe#2531
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
This diff modifies the tactics callbacks to take in input a context. We need the context to know whether the operation failed in itself or was canceled externally through the context. With this information, we can store better statistics about which tactics are working and which tactics are not working. While there, fix a couple of typos (thanks @robertodauria!) Part of ooni/probe#2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff modifies the tactics callbacks to take in input a context.
We need the context to know whether the operation failed in itself or was canceled externally through the context.
With this information, we can store better statistics about which tactics are working and which tactics are not working.
While there, fix a couple of typos (thanks @robertodauria!)
Part of ooni/probe#2531