Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(enginenetx): pass context to tactics callbacks #1286

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix(enginenetx): pass context to tactics callbacks #1286

merged 1 commit into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. fix(enginenetx): pass context to tactics callbacks 

    This diff modifies the tactics callbacks to take in input a context.

We need the context to know whether the operation failed in itself or
was canceled externally through the context.

With this information, we can store better statistics about which
tactics are working and which tactics are not working.

Part of ooni/probe#2531
    @bassosimone
    bassosimone committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    b64ffa0 View commit details
    Browse the repository at this point in the history