fix(oonimkall): make sure SoftwareName is set #1425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there, make sure we log the check-in request and response with `-v`, because otherwise 🤌🤌🤌🤌. Both part of ooni/probe#2644.
Murphy-OrangeMud
pushed a commit
to Murphy-OrangeMud/probe-cli
that referenced
this pull request
Feb 13, 2024
While there, make sure we log the check-in request and response with `-v`, because otherwise 🤌🤌🤌🤌. (On this note, we did not want to log psiphon and tor configs, but we're not using check-in for them anymore, so this switch from not logging to logging seems indeed to be reasonably okay to do. We need /api/v1/register and /api/v1/login before serving config. Additionally, it seems having experiment-specific APIs is actually more flexible anyway.) Part of ooni/probe#2644.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there, make sure we log the check-in request and response with
-v, because otherwise 🤌🤌🤌🤌. (On this note, we did not want to log psiphon and tor configs, but we're not using check-in for them anymore, so this switch from not logging to logging seems indeed to be reasonably okay to do. We need /api/v1/register and /api/v1/login before serving config. Additionally, it seems having experiment-specific APIs is actually more flexible anyway.)Part of ooni/probe#2644.