Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android: do not set timeout for unattended tests #2644

Closed
bassosimone opened this issue Dec 12, 2023 · 0 comments · Fixed by ooni/probe-android#643
Closed

android: do not set timeout for unattended tests #2644

bassosimone opened this issue Dec 12, 2023 · 0 comments · Fixed by ooni/probe-android#643
Assignees
@aanorbel
Labels
bug Something isn't working funder/otffoss2023-2024 ooni/probe-mobile issues related to OONI Probe mobile platform/android priority/high

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Dec 12, 2023 •
edited
Loading

We noticed with @FedericoCeratto, @aanorbel, @jbonisteel, and @agrabeli that ooni/probe-android 3.8.4 and 3.8.5 honour the maximum runtime both for foreground and background Web Connectivity runs. This change was introduced in ooni/probe-android#572, where we were trying to unify the codepaths for calling the check-in API.

In retrospect, though, applying a timeout for background runs is not what we want. The rationale of the timeout for foreground runs is because the backend returns possibly thousands of URLs. Measuring all these URLs by default would be impractical for interactive runs. This is the reason why we introduced a timeout parameter for allowing users to control the overall duration.

On the contrary, when testing in the backtground, the backend returns between 20 and 100 URLs, depending on the current phone configuration (Wi-Fi/mobile and charging/not charging). In such a scenario, enforcing a timeout is not required and actually is not optimal because it reduces the total amount of data we're able to collect.

(See probe_services.py#L235 for more details about the backend algorithm implementation.
@bassosimone bassosimone added bug Something isn't working ooni/probe-mobile issues related to OONI Probe mobile priority/high platform/android labels Dec 12, 2023
@bassosimone bassosimone mentioned this issue Dec 12, 2023
Merged
aanorbel added a commit to ooni/probe-android that referenced this issue Dec 12, 2023
@aanorbel
Fix: Timeout for unatted tests. (#643)
2e87252 
Fixes: ooni/probe#2644


## Proposed Changes

  - Check if the test is `unattended` before setting a timeout.
  - Reference issue: ooni/probe#2644
bassosimone added a commit to ooni/probe-cli that referenced this issue Dec 12, 2023
@bassosimone
fix(oonimkall): make sure SoftwareName is set
645cecb 
While there, make sure we log the check-in request and response
with `-v`, because otherwise 🤌🤌🤌🤌.

Both part of ooni/probe#2644.
@bassosimone bassosimone mentioned this issue Dec 12, 2023
Merged
bassosimone added a commit to ooni/probe-cli that referenced this issue Dec 12, 2023
@bassosimone
fix(oonimkall): make sure SoftwareName is set (#1425)
a91e86f 
While there, make sure we log the check-in request and response with
`-v`, because otherwise 🤌🤌🤌🤌. (On this note, we did not want to log
psiphon and tor configs, but we're not using check-in for them anymore,
so this switch from not logging to logging seems indeed to be reasonably
okay to do. We need /api/v1/register and /api/v1/login before serving
config. Additionally, it seems having experiment-specific APIs is
actually more flexible anyway.)

Part of ooni/probe#2644.
Murphy-OrangeMud pushed a commit to Murphy-OrangeMud/probe-cli that referenced this issue Feb 13, 2024
@bassosimone @Murphy-OrangeMud
fix(oonimkall): make sure SoftwareName is set (ooni#1425)
a952d71 
While there, make sure we log the check-in request and response with
`-v`, because otherwise 🤌🤌🤌🤌. (On this note, we did not want to log
psiphon and tor configs, but we're not using check-in for them anymore,
so this switch from not logging to logging seems indeed to be reasonably
okay to do. We need /api/v1/register and /api/v1/login before serving
config. Additionally, it seems having experiment-specific APIs is
actually more flexible anyway.)

Part of ooni/probe#2644.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aanorbel aanorbel

Labels
bug Something isn't working funder/otffoss2023-2024 ooni/probe-mobile issues related to OONI Probe mobile platform/android priority/high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Timeout for unatted tests. ooni/probe-android
2 participants
@bassosimone @aanorbel