fix(oohelperd): reduce errors to what the old TH would emit #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reducing the errors is not done in a perfect way. We have documented the most striking differences inside ooni/probe#1707 (comment) and some attempts to improve the situation further inside ooni/probe#1707 (comment). A better strategy for the future would be to introduce more specific timeout errors, such as dns_timeout_error, etc. More testing may be needed to further validate and compare the old and the new TH, but this requires Jafar improvements to more precisely simulate more complex censorship.
bassosimone
commented
Oct 13, 2021
8 tasks
bassosimone
added a commit
that referenced
this pull request
Oct 20, 2021
Reducing the errors is not done in a perfect way. We have documented the most striking differences inside ooni/probe#1707 (comment) and some attempts to improve the situation further inside ooni/probe#1707 (comment). A better strategy for the future would be to introduce more specific timeout errors, such as dns_timeout_error, etc. More testing may be needed to further validate and compare the old and the new TH, but this requires Jafar improvements to more precisely simulate more complex censorship. Backport from master; see ooni/probe#1839
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
Reducing the errors is not done in a perfect way. We have documented the most striking differences inside ooni/probe#1707 (comment) and some attempts to improve the situation further inside ooni/probe#1707 (comment). A better strategy for the future would be to introduce more specific timeout errors, such as dns_timeout_error, etc. More testing may be needed to further validate and compare the old and the new TH, but this requires Jafar improvements to more precisely simulate more complex censorship.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Location of the issue tracker: https://github.com/ooni/probe
Description
Reducing the errors is not done in a perfect way.
We have documented the most striking differences inside
ooni/probe#1707 (comment) and
some attempts to improve the situation further inside
ooni/probe#1707 (comment).
A better strategy for the future would be to introduce more
specific timeout errors, such as dns_timeout_error, etc.
More testing may be needed to further validate and compare the
old and the new TH, but this requires Jafar improvements to
more precisely simulate more complex censorship.