Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pull extra patches from master for 3.11.0 #1839

Closed
8 tasks done
bassosimone opened this issue Oct 20, 2021 · 1 comment
Closed
8 tasks done

chore: pull extra patches from master for 3.11.0 #1839

bassosimone opened this issue Oct 20, 2021 · 1 comment
Assignees
Labels
chore routine tasks that must be done, but require little active brain power

Comments

@bassosimone bassosimone added the chore routine tasks that must be done, but require little active brain power label Oct 20, 2021
@bassosimone bassosimone added this to the Sprint 50 - Amphipoda milestone Oct 20, 2021
@bassosimone bassosimone self-assigned this Oct 20, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 20, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 20, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 20, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 20, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 20, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 20, 2021
Reducing the errors is not done in a perfect way.

We have documented the most striking differences inside
ooni/probe#1707 (comment) and
some attempts to improve the situation further inside
ooni/probe#1707 (comment).

A better strategy for the future would be to introduce more
specific timeout errors, such as dns_timeout_error, etc.

More testing may be needed to further validate and compare the
old and the new TH, but this requires Jafar improvements to
more precisely simulate more complex censorship.

Backport from master; see ooni/probe#1839
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 20, 2021
Matches the behavior that the legacy TH implements in this
situation and reduces slightly the differences.

See ooni/probe#1707 (comment)

Backport from master; see ooni/probe#1839
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 20, 2021
bassosimone added a commit to ooni/probe-cli that referenced this issue Oct 20, 2021
stable: backport from master useful patches for 3.11.0 

See ooni/probe#1839
@bassosimone
Copy link
Contributor Author

Done in ooni/probe-cli#549

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore routine tasks that must be done, but require little active brain power
Projects
None yet
Development

No branches or pull requests

1 participant