fix(wcth): emit empty Addrs when input URL contains addr #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches the behavior that the legacy TH implements in this situation and reduces slightly the differences. See ooni/probe#1707 (comment)
This was referenced Oct 18, 2021
bassosimone
added a commit
that referenced
this pull request
Oct 20, 2021
Matches the behavior that the legacy TH implements in this situation and reduces slightly the differences. See ooni/probe#1707 (comment) Backport from master; see ooni/probe#1839
ainghazal
pushed a commit
to ainghazal/probe-cli
that referenced
this pull request
Mar 8, 2022
Matches the behavior that the legacy TH implements in this situation and reduces slightly the differences. See ooni/probe#1707 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Location of the issue tracker: https://github.com/ooni/probe
Description
Matches the behavior that the legacy TH implements in this
situation and reduces slightly the differences.
See ooni/probe#1707 (comment)