feat(dns): expose more low-level fields #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using this type to write tests ~one year ago but, as of today, this type is mostly unused. Make it actually unused, which helps moving ooni/probe#1516 forward.
This diff extends measurexlite's extractor to include into the DNS response we submit the raw response we received. The reference issue is ooni/probe#1516
Rather than discarding the CNAME, make sure we can actually get the CNAME inside of the main LookupHost function. Part of ooni/probe#1516.
|
Here's what is currently missing:
When all of this is done, All this work as been done in other PRs that extracted patches from this one, for clarity. |
bassosimone
changed the title
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request started as a draft to enable users to see CNAME answers. It contained several patches which we merged separately (see #873 (comment) and 2301a30...60b7d1f for details on what has actually changed, which is based on patches originally part of this PR). In its final form, however, this PR only deals with exposing more low-level DNS fields to the archival data format.
Closes: ooni/probe#2228
Related PR spec: ooni/spec#256