Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnst: document new fields #256

Merged
merged 6 commits into from
Aug 23, 2022
Merged

dnst: document new fields #256

merged 6 commits into from
Aug 23, 2022

Conversation

bassosimone
Copy link
Contributor

@bassosimone bassosimone commented Aug 23, 2022 •
edited
Loading

Checklist

bassosimone added a commit to ooni/probe-cli that referenced this pull request Aug 23, 2022
@bassosimone
feat(dns): expose more low-level fields
37767f0 
Closes: ooni/probe#2228

Related spec PR: ooni/spec#256
@bassosimone bassosimone mentioned this pull request Aug 23, 2022
Merged
@bassosimone bassosimone marked this pull request as ready for review August 23, 2022 13:50
@bassosimone bassosimone requested a review from hellais as a code owner August 23, 2022 13:50
@bassosimone bassosimone merged commit 85bf910 into master Aug 23, 2022
@bassosimone bassosimone deleted the bassosimone-patch-1 branch August 23, 2022 14:06
bassosimone added a commit to ooni/probe-cli that referenced this pull request Aug 23, 2022
@bassosimone
feat(dns): expose more low-level fields (#873)
c9943df 
This pull request started as a draft to enable users to see CNAME answers. It contained several patches which we merged separately (see #873 (comment) and 2301a30...60b7d1f for details on what has actually changed, which is based on patches originally part of this PR). In its final form, however, this PR only deals with exposing more low-level DNS fields to the archival data format.

Closes: ooni/probe#2228

Related PR spec: ooni/spec#256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mScott224 mScott224 mScott224 approved these changes

@hellais hellais Awaiting requested review from hellais hellais is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bassosimone @mScott224