Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jafar: add integration tests for sniblocking #1625

Closed
3 tasks
bassosimone opened this issue Mar 7, 2020 · 1 comment
Closed
3 tasks

jafar: add integration tests for sniblocking #1625

bassosimone opened this issue Mar 7, 2020 · 1 comment
Assignees
@bassosimone
Labels
ooni/probe-engine priority/low wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)

Comments

@bassosimone
Copy link
Contributor

  • add /QA/sniblocking.py patterned after /QA/telegram.py (or any other file in there)
  • modify /QA/sniblocking.py so that we exercise the sniblocking experiment
  • add the newly added QA script to /.github/workflows/qa.yml
@bassosimone bassosimone self-assigned this Mar 7, 2020
bassosimone referenced this issue in ooni/probe-engine Mar 9, 2020
@bassosimone
sniblocking: revamp classification mechanism
bef0e39 
Part of #309

Makes https://github.com/ooni/probe-engine/issues/393 unnecessary

This is the result of a two hours brainstorming and pair
programming session with @fortuna, where we reviewed existing
codebase, and design, and we spelled out a classification
taxonomy more oriented towards communicating with a OONI user.
@bassosimone bassosimone changed the title sniblocking: reliably detect TLS MITM jafar: add integration tests for sniblocking Mar 9, 2020
@hellais hellais transferred this issue from ooni/probe-engine Jun 11, 2021
@bassosimone bassosimone added the wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case) label Jun 7, 2022
@bassosimone
Copy link
Contributor Author

Jafar is flaky. We need better ways of running QA where we don't depend on real services. See #2129 and #2128 for some examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
ooni/probe-engine priority/low wontfix when an issue won't be addressed (add a comment to the issue as to why this is the case)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bassosimone @hellais