Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experiment/sni_blocking: address feedback from @fortuna #309

Closed
5 tasks done
bassosimone opened this issue Feb 1, 2020 · 3 comments
Closed
5 tasks done

experiment/sni_blocking: address feedback from @fortuna #309

bassosimone opened this issue Feb 1, 2020 · 3 comments
Assignees
@bassosimone
Labels
effort/S Small effort enhancement New feature or request ooni/probe-engine Issues related to github.com/ooni/probe-engine ooni/spec Issues related to github.com/ooni/spec priority/high High priority user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Milestone
Sprint 8 - Flounder

Comments

@bassosimone
Copy link
Contributor

bassosimone commented Feb 1, 2020 •
edited
Loading

@bassosimone bassosimone added enhancement New feature or request priority/high High priority effort/S Small effort user feedback requests that have been added to the backlog as a direct result of user feedback or testing ooni/spec Issues related to github.com/ooni/spec ooni/probe-engine Issues related to github.com/ooni/probe-engine interrupt Task not planned during planning labels Feb 1, 2020
@bassosimone bassosimone added this to the Sprint 6 - Dumbo Octopus milestone Feb 1, 2020
@bassosimone bassosimone self-assigned this Feb 1, 2020
@bassosimone bassosimone mentioned this issue Feb 1, 2020
Merged
@bassosimone bassosimone mentioned this issue Feb 11, 2020
Closed
@bassosimone bassosimone removed the interrupt Task not planned during planning label Feb 17, 2020
@bassosimone bassosimone mentioned this issue Mar 6, 2020
Closed
bassosimone added a commit that referenced this issue Mar 6, 2020
@bassosimone
sniblocking: cache recent results
80f620f 
Avoids requesting several times in a row for the control SNI, which
is frankly a waste of time when checkoing multiple inputs.

While there, make sure we never use ps.ooni.io as the helper. A bunch
of places in tests were still using it, which is generally fine but
being consistent is most likely gonna be better.

Part of #309.
@bassosimone bassosimone mentioned this issue Mar 6, 2020
Merged
bassosimone added a commit that referenced this issue Mar 6, 2020
@bassosimone
sniblocking: cache recent results (#390)
030e792 
Avoids requesting several times in a row for the control SNI, which
is frankly a waste of time when checkoing multiple inputs.

While there, make sure we never use ps.ooni.io as the helper. A bunch
of places in tests were still using it, which is generally fine but
being consistent is most likely gonna be better.

Part of #309.
bassosimone added a commit that referenced this issue Mar 6, 2020
@bassosimone
sniblocking: classify failures to produce a result
f00553a 
Since in OONI we typically use a three class system (i.e. accessible,
anomaly, or blocking), I am using these three classes.

I am also adding further information that help in understanding what
is the real root cause of the failure.

Part of #309.
@bassosimone bassosimone mentioned this issue Mar 6, 2020
Merged
3 tasks
bassosimone added a commit to ooni/spec that referenced this issue Mar 7, 2020
@bassosimone
ts-024-sni-blocking.md: document result classification
48af151 
Implemented at ooni/probe-engine#391.

Part of ooni/probe-engine#309.
@bassosimone bassosimone mentioned this issue Mar 7, 2020
Merged
bassosimone added a commit to ooni/spec that referenced this issue Mar 7, 2020
@bassosimone
ts-024-sni-blocking.md: document result classification (#181)
99c0f83 
Implemented at ooni/probe-engine#391.

Part of ooni/probe-engine#309.
bassosimone added a commit that referenced this issue Mar 7, 2020
@bassosimone
sniblocking: classify failures to produce a result (#391)
30ee2a6 
Since in OONI we typically use a three class system (i.e. accessible,
anomaly, or blocking), I am using these three classes.

I am also adding further information that help in understanding what
is the real root cause of the failure.

Part of #309.
bassosimone added a commit to ooni/spec that referenced this issue Mar 7, 2020
@bassosimone
ts-024-sni-blocking.md: better document design choices
d3aa149 
See ooni/probe-engine#309
@bassosimone bassosimone mentioned this issue Mar 7, 2020
Merged
bassosimone added a commit to ooni/spec that referenced this issue Mar 7, 2020
@bassosimone
ts-024-sni-blocking.md: better document design choices (#182)
794e9e9 
See ooni/probe-engine#309
@bassosimone
Copy link
Contributor Author

All done!

@bassosimone
Copy link
Contributor Author

Did a two hours session with @fortuna today and we improved the design. PRs for both the code and the spec are coming right away. Will close when both are merged.

@bassosimone bassosimone reopened this Mar 9, 2020
bassosimone added a commit that referenced this issue Mar 9, 2020
@bassosimone
sniblocking: revamp classification mechanism
bef0e39 
Part of #309

Makes https://github.com/ooni/probe-engine/issues/393 unnecessary

This is the result of a two hours brainstorming and pair
programming session with @fortuna, where we reviewed existing
codebase, and design, and we spelled out a classification
taxonomy more oriented towards communicating with a OONI user.
@bassosimone bassosimone mentioned this issue Mar 9, 2020
Merged
bassosimone added a commit to ooni/spec that referenced this issue Mar 9, 2020
@bassosimone
ts-024-sni-blocking.md: address @fortuna's feedback
7bfa33c 
With @fortuna we had today a 1:1 meeting where we improved the design
of sni-blocking classification to make it easier to understand.

This diff implements the changes we agreed to apply.

Sibling of ooni/probe-engine#397.

Part of ooni/probe-engine#309.
@bassosimone bassosimone mentioned this issue Mar 9, 2020
Merged
bassosimone added a commit to ooni/spec that referenced this issue Mar 9, 2020
@bassosimone
ts-024-sni-blocking.md: address @fortuna's feedback (#183)
adf9537 
With @fortuna we had today a 1:1 meeting where we improved the design
of sni-blocking classification to make it easier to understand.

This diff implements the changes we agreed to apply.

Sibling of ooni/probe-engine#397.

Part of ooni/probe-engine#309.
bassosimone added a commit that referenced this issue Mar 9, 2020
@bassosimone
sniblocking: revamp classification mechanism (#397)
bb5f400 
Part of #309

This is the result of a two hours brainstorming and pair
programming session with @fortuna, where we reviewed existing
codebase, and design, and we spelled out a classification
taxonomy more oriented towards communicating with a OONI user.
@bassosimone
Copy link
Contributor Author

Further changes merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bassosimone bassosimone

Labels
effort/S Small effort enhancement New feature or request ooni/probe-engine Issues related to github.com/ooni/probe-engine ooni/spec Issues related to github.com/ooni/spec priority/high High priority user feedback requests that have been added to the backlog as a direct result of user feedback or testing
Projects
None yet
Milestone
Sprint 8 - Flounder
Development

No branches or pull requests
1 participant
@bassosimone