Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write spec for SNI blocking experiment #159

Merged
merged 9 commits into from
Jan 28, 2020
Merged

Write spec for SNI blocking experiment #159

merged 9 commits into from
Jan 28, 2020

Conversation

bassosimone
Copy link
Contributor

No description provided.

@bassosimone bassosimone requested a review from hellais October 8, 2019 17:00
@bassosimone bassosimone self-assigned this Oct 8, 2019
@bassosimone bassosimone marked this pull request as ready for review October 8, 2019 17:02
@bassosimone bassosimone mentioned this pull request Oct 8, 2019
Closed
@bassosimone
Copy link
Contributor Author

@hellais I have addressed your feedback, I hope! Please, take another look!

@bassosimone bassosimone force-pushed the feature/sni-blocking branch from fbe3045 to 566f2e0 Compare October 9, 2019 13:36
@bassosimone bassosimone force-pushed the feature/sni-blocking branch from 566f2e0 to 2d31c17 Compare October 9, 2019 13:48
fortuna
fortuna suggested changes Oct 9, 2019
View reviewed changes
nettests/ts-024-sni-blocking.md Outdated Show resolved Hide resolved
nettests/ts-024-sni-blocking.md Outdated Show resolved Hide resolved
fortuna
fortuna suggested changes Oct 9, 2019
View reviewed changes
nettests/ts-024-sni-blocking.md Outdated Show resolved Hide resolved
@bassosimone bassosimone merged commit 8353536 into master Jan 28, 2020
@bassosimone bassosimone deleted the feature/sni-blocking branch January 28, 2020 15:34
fortuna
fortuna reviewed Feb 1, 2020
View reviewed changes
Copy link

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exciting. I'm glad to see this happening!

nettests/ts-024-sni-blocking.md Show resolved Hide resolved
nettests/ts-024-sni-blocking.md Show resolved Hide resolved
nettests/ts-024-sni-blocking.md Show resolved Hide resolved
nettests/ts-024-sni-blocking.md Show resolved Hide resolved
nettests/ts-024-sni-blocking.md Show resolved Hide resolved
bassosimone added a commit that referenced this pull request Feb 1, 2020
@bassosimone
ts-024-sni-blocking.md: clarify testhelper type
45741cc 
Xref: #159 (comment)
@bassosimone bassosimone mentioned this pull request Feb 1, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellais hellais hellais left review comments

@fortuna fortuna fortuna requested changes

@darkk darkk darkk left review comments

Assignees

@bassosimone bassosimone

Labels
new test priority/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bassosimone @darkk @fortuna @hellais