probe-android: review OONI Dev 3.8.5.1-beta.1 (20240126)

[hellais]

This is the issue to track feedback for: ooni/probe-android#636

[hellais]

Feedback:

• 🔴 When I first opened the app every test card except Websites and Instant Messaging was greyed out not allowing me to tap on them. Now everything except Websites is greyed out.
• 🔴 When I tap inside of the websites card. The Run automatically option for Websites cannot be deselected. Toggled and not changeable.
• 🟡 I think the read more option can include more text before you need to truncate it. On my phone screen the text inside of the websites card fits well within the screen allowing me to see the buttons under it too.
• 🟦 Related to this, we may want to have a nicer pattern for the expand/collapse by using a style that doesn't conflict with the style we are already using for links
• 🟡 When I tap the timed run button, it doesn't remember the settings from the last run I made. It always reverts back to having only the websites group being selected. It should instead remember how it was configured for the last run and preserve that setup.

🔴 == essential feedback (p0)
🟡 == important feedback (p1)
🟦 == nice to have (p2)

[aanorbel]

The following release addresses all the above points of feedback: https://appdistribution.firebase.google.com/testerapps/1:951667061699:android:13ca15ecce8c0f15374376/releases/022gojfbe7588?utm_source=firebase-console

[hellais]

🔴 When I first opened the app every test card except Websites and Instant Messaging was greyed out not allowing me to tap on them. Now everything except Websites is greyed out.

I tested the above release and there is still something broken here.

I ran a few tests and for some unexplainable reason one of the cards became deselected and toggled off.

Do you know what's up with that?

Edit: I think I understand now what the issue is. For some reason the selection of the tests in the run all tests view affects which cards are tappable and selected or not in the dashboard.

I think we have removed since several revisions of the designs the concept of a card being disabled in the dashboard, so all code related to this feature should be removed and this bug should be fixed.

[hellais]

🟡 I think the read more option can include more text before you need to truncate it. On my phone screen the text inside of the websites card fits well within the screen allowing me to see the buttons under it too.

This still needs some tweaking. I think that for the default OONI tests it's not needed to have the read more.

🟦 Related to this, we may want to have a nicer pattern for the expand/collapse by using a style that doesn't conflict with the style we are already using for links

This is also not addressed, it has stayed the same.

[hellais]

I would say this can be closed as the issues have been discussed and resolved.