Dev: Update OONI to use new Design System #636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ooni/probe#2596 ## Proposed Changes - Update designs for Run v1 components to match new designs - Add `SrtingListRecyclerViewAdapter` to display List items - Convert `OoniRunActivity` to Kotlin | Light | Dark| |--|--| |.|.| ||| || | ||| ||| ||| ||| ||?
… new components (#629) Fixes ooni/probe#2591 ## Proposed Changes - Removes `Run` button. - Adds `Read more >` plugin to markdown text |.|.| |-|-| | || |||
Closed
Fixes ooni/probe#2588 ## Proposed Changes - Update XML designs - Convert `ProgressFragment` to kotlin |.|.| |-|-| |  |  | | | |
Fixes ooni/probe#2592 ## Proposed Changes - Updated `CustomWebsiteActivity` to use new theme. - Change List item builder to use `RecyclerView`. Tasks - [x] Implement designs on light theme. - [x] Convert list item builder to use `RecyclerView`. - [x] Fix dark theme - [x] Implement modal properly | Light | Dark| |-|-| |)|  | ||  | |  |  | --------- Co-authored-by: Simone Basso <bassosimone@gmail.com>
…r selecting desired tests (#632) Fixes ooni/probe#2589 build: https://github.com/ooni/probe-android/suites/18778645278/artifacts/1094292643 ## Proposed Changes - Add `RunTestsActivity` and related components |.|.| |-|-| |  |  | |  |  | --------- Co-authored-by: Simone Basso <bassosimone@gmail.com>
Fixes ooni/probe#2593 ## Proposed Changes - Merge `Automated Testing` settings into whats left of `Test Options` |.|.| |-|-| |  |  |
## Proposed Changes - Add `OONIDescriptor` and methods to transform to `DynamicSuite` - Update various components to use descriptors - Update tests --------- Co-authored-by: Simone Basso <bassosimone@gmail.com>
## Proposed Changes - Update `activity_overview.xml` to include list to display tests. - Add `OverviewTestsExpandableListViewAdapter.kt` and `OverviewViewModel.kt` to display the list and control actions. - Update `OverviewActivity` with various callbacks. |.|.|.| |-|-|-| | | | | **NOTE** : Switches in designs replaced with checkbox since the switch does not have an intermediate state. The intermediate state is important when some of the component tests are disabled but not all are disabled. --------- Co-authored-by: Simone Basso <bassosimone@gmail.com>
…o dev/design-update
…com:ooni/probe-android into dev/design-update
Fixes OONI cards not enabled by default. ## Proposed Changes - Set default value for ooni tests to enabled.
Fixes ooni/probe#2659 (comment) ## Proposed Changes - Update `ReadMorePlugin` to take a `maxLength` parameter with default value `150`. - Update `OverviewActivity` to allow modification of all automated update items. - Update `RunTestsActivity` to save preferences only when the tests are run.
…obe-android into dev/design-update
## Proposed Changes - Update `MeasurementDetailActivity` to check test names when displaying performance results. - Update `ResultDetailActivity` to use colour of results in themes setup and use `Experimental` test names to determine where to navigate when the measurement is clicked.
fix: Updated `ProgressFragment` and its position on dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes