Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(client): Add compute_output_root to block executor #225

Merged
merged 1 commit into from
Jun 11, 2024
Merged

feat(client): Add compute_output_root to block executor #225

merged 1 commit into from
Jun 11, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jun 8, 2024

Overview

Adds a function to the block executor that allows for generating the current output root, based on the parent timestamp and current trie.

This was referenced Jun 8, 2024
Merged
Merged
@clabby Graphite App
Copy link
Collaborator Author

clabby commented Jun 8, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clabby and the rest of your teammates on Graphite Graphite

@clabby clabby mentioned this pull request Jun 8, 2024
Merged
@clabby clabby force-pushed the cl/client-block-executor branch from bb6b6c2 to f66be56 Compare June 8, 2024 20:36
@clabby clabby force-pushed the cl/output-root-generation branch from 0b5b959 to bc40428 Compare June 8, 2024 20:36
@clabby clabby self-assigned this Jun 8, 2024
@clabby clabby added A-client Area: client binary K-feature Kind: feature labels Jun 8, 2024
@clabby clabby changed the title feat(client): Add current_output_root to block executor feat(client): Add compute_output_root to block executor Jun 8, 2024
@clabby clabby requested a review from refcell June 9, 2024 18:21
@clabby clabby mentioned this pull request Jun 10, 2024
Merged
refcell
refcell approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@clabby
feat(client): Add current_output_root to block executor
5bb3e43 
Adds a function to the block executor that allows for generating the
current output root, based on the parent timestamp and current trie.
@clabby clabby force-pushed the cl/output-root-generation branch from bc40428 to 5bb3e43 Compare June 10, 2024 14:29
@clabby clabby changed the base branch from cl/client-block-executor to main June 10, 2024 14:29
@clabby clabby mentioned this pull request Jun 11, 2024
Merged
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Jun 11, 2024
@refcell refcell added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit 1526ecc Jun 11, 2024
13 checks passed
This was referenced Jun 11, 2024
Closed
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jun 22, 2024
Merged
@clabby clabby deleted the cl/output-root-generation branch July 2, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refcell refcell refcell approved these changes

Assignees

@clabby clabby

Labels
A-client Area: client binary K-feature Kind: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clabby @refcell