Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(host): More hint routes #232

Merged
merged 1 commit into from
Jun 14, 2024
Merged

feat(host): More hint routes #232

merged 1 commit into from
Jun 14, 2024

Conversation

clabby
Copy link
Collaborator

@clabby clabby commented Jun 11, 2024

Overview

Implements several more hint routes in the host program

@clabby clabby force-pushed the cl/more-host-hints branch from a451514 to 7ae7948 Compare June 11, 2024 01:44
@clabby clabby added this to the Phase 3: Kona Client & Host milestone Jun 11, 2024
Copy link
Collaborator

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request for github issues over inline TODO comments.

@clabby clabby force-pushed the cl/more-host-hints branch from 7ae7948 to 983ce1d Compare June 14, 2024 18:10
@clabby clabby changed the base branch from cl/trie-hints to main June 14, 2024 18:10
Implements several more hint routes in the host program
@clabby clabby force-pushed the cl/more-host-hints branch from 983ce1d to 52268f8 Compare June 14, 2024 18:14
@clabby clabby requested a review from refcell June 14, 2024 18:14
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes missing coverage. Please review.

Project coverage is 73.7%. Comparing base (5d327d2) to head (52268f8).

Files Patch % Lines
bin/host/src/fetcher/mod.rs 0.0% 86 Missing ⚠️
bin/host/src/fetcher/hint.rs 0.0% 2 Missing ⚠️
bin/host/src/main.rs 0.0% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@refcell refcell added this pull request to the merge queue Jun 14, 2024
Merged via the queue into main with commit b24f145 Jun 14, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
@clabby clabby deleted the cl/more-host-hints branch June 14, 2024 19:25
@zobront zobront mentioned this pull request Jun 14, 2024
2 tasks
@github-actions github-actions bot mentioned this pull request Jun 16, 2024
@github-actions github-actions bot mentioned this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-host Area: host binary K-feature Kind: feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants