Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document poetry version and update #43

Merged
merged 2 commits into from
Feb 19, 2022
Merged

Conversation

palfrey
Copy link
Contributor

@palfrey palfrey commented Feb 5, 2022

I'm trying to do something else (test and fix mediadb_storage with Python 3.x), and ran into issues because the poetry.lock was generated with what I think is a 1.0.x version of poetry, and I needed 1.1.x for some bug fixes. They've since changed the lock format (which is annoying) and also added in a lock-version field inside there that at least documents what format was used. This PR should just update the poetry.lock and document a known-good "will get the same answers" version of poetry.

@palfrey palfrey mentioned this pull request Feb 6, 2022
@codecov
Copy link

codecov bot commented Feb 19, 2022

Codecov Report

Merging #43 (0532dcb) into master (25e6a85) will decrease coverage by 0.02%.
The diff coverage is 38.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #43      +/-   ##
==========================================
- Coverage   47.27%   47.24%   -0.03%     
==========================================
  Files          50       50              
  Lines       10826    10826              
==========================================
- Hits         5118     5115       -3     
- Misses       5708     5711       +3     
Flag Coverage Δ
unittest 47.24% <38.46%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
coherence/backends/fs_storage.py 43.26% <0.00%> (ø)
coherence/upnp/core/service.py 66.44% <0.00%> (ø)
coherence/upnp/devices/media_server.py 33.33% <ø> (ø)
coherence/base.py 58.23% <40.00%> (-0.44%) ⬇️
coherence/upnp/core/device.py 73.41% <66.66%> (-0.06%) ⬇️
coherence/upnp/devices/control_point.py 38.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5779b4...0532dcb. Read the comment docs.

Copy link
Owner

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, thanks!!

@opacam opacam merged commit 711b26d into opacam:master Feb 19, 2022
@palfrey palfrey deleted the poetry-1.1 branch February 19, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants