Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assert_operation_response header lookup #584

Merged

Conversation

msutkowski
Copy link
Contributor

@msutkowski msutkowski commented Dec 16, 2023

Fixes #575.

  • Modifies Utils.content_type_from_header to accept a header location
  • Updates assert_operation_response to pass in :response to the above fn
  • Simplifies error messages for schema resolution failures

@msutkowski msutkowski force-pushed the ms/fix-assert-operation-response branch from 978ff04 to 9deee85 Compare December 16, 2023 18:48
@zorbash zorbash merged commit fb02fb7 into open-api-spex:master Dec 18, 2023
12 checks passed
hou8 pushed a commit to hou8/open_api_spex that referenced this pull request Apr 18, 2024
* fix: assert_operation_response header lookup
hamir-suspect added a commit to renderedtext/open_api_spex that referenced this pull request May 14, 2024
* Exclude empty paths from spec (open-api-spex#583)

* Exclude empty paths from spec

* fix: assert_operation_response header lookup (open-api-spex#584)

* fix: assert_operation_response header lookup

* Release version 3.18.1

* Fix 'AllOf cast returns a map, but I expected a struct' (open-api-spex#592)

* Add failing test

* Cast result of AllOf cast into a struct

* Shorter module name

* Add missing NoneCache test

* Release version 3.18.2

* Relax dependency constraint on ymlr to allow version ~> 5.0 (open-api-spex#586)

* relax dependency on ymlr, and fix some tests

* test with more elixir versions

* Update Elixir version test matrix (open-api-spex#602)

* Update Elixir version test matrix

* Fix map key order dependent test

* Release version 3.18.3

* Support response code ranges

See: https://swagger.io/docs/specification/describing-responses/

* Release version 3.19.0

* Add notice that body params are not merged into Conn.params whne using cast and validate plug (open-api-spex#589)

* Set nonces on <script> and <style> elements if configured (open-api-spex#593)

* Allow script and style nonces

* Allow nonces on the SwaggerUIOAuth2Redirect plug as well

---------

Co-authored-by: Alisina Bahadori <alisina.bm@gmail.com>
Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>
Co-authored-by: Dimitris Zorbas <dimitrisplusplus@gmail.com>
Co-authored-by: Angelika Tyborska <angelikatyborska@fastmail.com>
Co-authored-by: Aleksandr Lossenko <aleksandr.lossenko@memsource.com>
Co-authored-by: Nathan Alderson <me@nathanalderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assert_operation_response is (incorrectly) based on the request's content type, not the response's.
2 participants