Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'AllOf cast returns a map, but I expected a struct' #592

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Fix 'AllOf cast returns a map, but I expected a struct' #592

merged 3 commits into from
Jan 16, 2024

Conversation

angelikatyborska
Copy link
Contributor

Resolves #590

zorbash
zorbash reviewed Jan 16, 2024
View reviewed changes
test/cast/all_of_test.exs Outdated
@@ -355,6 +355,8 @@ defmodule OpenApiSpex.CastAllOfTest do

test "with schema having x-type" do
value = %{fur: true, meow: true}
assert {:ok, _} = cast(value: value, schema: CatSchema.schema())

assert {:ok, %OpenApiSpex.CastAllOfTest.CatSchema{fur: true, meow: true}} =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit]

diff --git a/test/cast/all_of_test.exs b/test/cast/all_of_test.exs
index 93487fa..9f2fbab 100644
--- a/test/cast/all_of_test.exs
+++ b/test/cast/all_of_test.exs
@@ -356,7 +356,6 @@ defmodule OpenApiSpex.CastAllOfTest do
   test "with schema having x-type" do
     value = %{fur: true, meow: true}
 
-    assert {:ok, %OpenApiSpex.CastAllOfTest.CatSchema{fur: true, meow: true}} =
-             cast(value: value, schema: CatSchema.schema())
+    assert {:ok, %CatSchema{fur: true, meow: true}} = cast(value: value, schema: CatSchema.schema())
   end
 end

@zorbash zorbash merged commit 0b1396c into open-api-spex:master Jan 16, 2024
12 checks passed
hou8 pushed a commit to hou8/open_api_spex that referenced this pull request Apr 18, 2024
@angelikatyborska
Fix 'AllOf cast returns a map, but I expected a struct' (open-api-spe…
45e8436 
…x#592)

* Add failing test

* Cast result of AllOf cast into a struct

* Shorter module name
hamir-suspect added a commit to renderedtext/open_api_spex that referenced this pull request May 14, 2024
@hamir-suspect @alisinabh
@msutkowski @zorbash @angelikatyborska @nathanalderson
Sync with upstream (#2)
a1de716 
* Exclude empty paths from spec (open-api-spex#583)

* Exclude empty paths from spec

* fix: assert_operation_response header lookup (open-api-spex#584)

* fix: assert_operation_response header lookup

* Release version 3.18.1

* Fix 'AllOf cast returns a map, but I expected a struct' (open-api-spex#592)

* Add failing test

* Cast result of AllOf cast into a struct

* Shorter module name

* Add missing NoneCache test

* Release version 3.18.2

* Relax dependency constraint on ymlr to allow version ~> 5.0 (open-api-spex#586)

* relax dependency on ymlr, and fix some tests

* test with more elixir versions

* Update Elixir version test matrix (open-api-spex#602)

* Update Elixir version test matrix

* Fix map key order dependent test

* Release version 3.18.3

* Support response code ranges

See: https://swagger.io/docs/specification/describing-responses/

* Release version 3.19.0

* Add notice that body params are not merged into Conn.params whne using cast and validate plug (open-api-spex#589)

* Set nonces on <script> and <style> elements if configured (open-api-spex#593)

* Allow script and style nonces

* Allow nonces on the SwaggerUIOAuth2Redirect plug as well

---------

Co-authored-by: Alisina Bahadori <alisina.bm@gmail.com>
Co-authored-by: Matt Sutkowski <msutkowski@gmail.com>
Co-authored-by: Dimitris Zorbas <dimitrisplusplus@gmail.com>
Co-authored-by: Angelika Tyborska <angelikatyborska@fastmail.com>
Co-authored-by: Aleksandr Lossenko <aleksandr.lossenko@memsource.com>
Co-authored-by: Nathan Alderson <me@nathanalderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zorbash zorbash zorbash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AllOf cast returns a map, but I expected a struct
2 participants
@angelikatyborska @zorbash