Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues with the new 2D advection-diffusion example #453

Closed
7 tasks done
slayoo opened this issue Sep 8, 2024 · 7 comments
Closed
7 tasks done

issues with the new 2D advection-diffusion example #453

slayoo opened this issue Sep 8, 2024 · 7 comments

Comments

@slayoo
Copy link
Member

slayoo commented Sep 8, 2024

@pawelmagnu, here's an update on the post-merge status for #427:

  • animation is not properly uploaded to "tip" release (file not found error in the logs) - this blocks upload to PyPI
  • when executing on mybinder.org, there is "ModuleNotFoundError: No module named 'imageio'" error
  • Colab badge in the notebook has wrong URL
  • there is no link/badge in the examples/README.md leading to the new examples
  • figures in the notebook are not displayed when viewed on GitHub - there are just blank white panels
  • no "view on github" badge in the notebook
  • some header comment with a hint on what is being computed in the notebook would be very helpful

Let's aim at fixing it next week

Kojec1 added a commit to Kojec1/PyMPDATA that referenced this issue Sep 15, 2024
… requirements for Binder; View on github badge; Corrected colab url; Link and badges in README;
@pawelmagnu
Copy link
Collaborator

@Kojec1 could you check which points have already been addressed in #456 ?

@Kojec1
Copy link
Collaborator

Kojec1 commented Sep 16, 2024

There's still an issue with the figures displayed on GitHub, missing header information and I haven't managed to check if the .gif file is successfully uploaded to the "tip" release. The other issues seem to be solve.

@pawelmagnu
Copy link
Collaborator

I'm pretty sure we can't check if the .gif file uploads before actually merging to main.

github-merge-queue bot pushed a commit that referenced this issue Sep 19, 2024
Co-authored-by: Kojec1 <konrad.pawlik333@gmail.com>
Co-authored-by: Sylwester Arabas <sylwester.arabas@agh.edu.pl>
@slayoo
Copy link
Member Author

slayoo commented Sep 22, 2024

.gif file upload works!
The notebook does not work on Colab yet as it fails on first line with:
image
This is due to lack of pip install ... commands for Colab in an initial notebook cell, like we do in other notebooks.
Here's a PR addressing it: #458

@slayoo
Copy link
Member Author

slayoo commented Oct 6, 2024

Just tested both on Colab and mybinder.org, and everything works!
So, we're still missing two things:

  • figures in the notebook are not displayed when viewed on GitHub - notebook was committed with cell output cleared
  • some header comment with a hint on what is being computed in the notebook would be very helpful

@pawelmagnu
Copy link
Collaborator

addressed in #462

@slayoo slayoo changed the title issues with the new 2D advection-duffusion example issues with the new 2D advection-diffusion example Oct 16, 2024
@slayoo slayoo closed this as completed Oct 16, 2024
@slayoo
Copy link
Member Author

slayoo commented Oct 16, 2024

kudos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants