Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to adv-diff-2d examples as mentioned in issue #453 #456

Merged
merged 11 commits into from
Sep 19, 2024

Conversation

pawelmagnu
Copy link
Collaborator

No description provided.

@pawelmagnu pawelmagnu changed the title fix to adv-diff-2d examples as mentioned in https://github.com/open-atmos/PyMPDATA/issues/453 fix to adv-diff-2d examples as mentioned in #453 Sep 16, 2024
@pawelmagnu pawelmagnu changed the title fix to adv-diff-2d examples as mentioned in #453 fix to adv-diff-2d examples as mentioned in issue #453 Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (eb501f3) to head (b605b9a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #456   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          30       30           
  Lines        1468     1468           
=======================================
  Hits         1351     1351           
  Misses        117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pawelmagnu pawelmagnu requested a review from slayoo September 18, 2024 17:19
…le to check ifthe selected files are actually present)
@slayoo slayoo mentioned this pull request Sep 19, 2024
@slayoo slayoo added this pull request to the merge queue Sep 19, 2024
@slayoo
Copy link
Member

slayoo commented Sep 19, 2024

thanks @Kojec1 & @pawelmagnu

Merged via the queue into open-atmos:main with commit 629b413 Sep 19, 2024
29 checks passed
@slayoo
Copy link
Member

slayoo commented Sep 21, 2024

the animation in the docs works!
https://open-atmos.github.io/PyMPDATA/PyMPDATA_examples.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants