Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pybind11_json to fix AeroMode::ctor segfault case (reported and fixed upstream by @dbaston) #319

Closed
slayoo opened this issue Dec 2, 2023 · 4 comments

Comments

@slayoo
Copy link
Member

slayoo commented Dec 2, 2023

No description provided.

Copy link

github-actions bot commented Feb 1, 2024

Stale issue message

@slayoo
Copy link
Member Author

slayoo commented Feb 22, 2024

there is a test depicting it in the test suite:

def test_segfault_case(): # TODO #319
pytest.skip()
aero_data = ppmc.AeroData(AERO_DATA_CTOR_ARG_MINIMAL)
fishy_ctor_arg = copy.deepcopy(AERO_MODE_CTOR_LOG_NORMAL)
fishy_ctor_arg["test_mode"]["mass_frac"].append(
fishy_ctor_arg["test_mode"]["mass_frac"]
)
print(fishy_ctor_arg)
ppmc.AeroMode(aero_data, fishy_ctor_arg)

@slayoo slayoo added the good first issue Good for newcomers label Feb 22, 2024
@slayoo slayoo changed the title report AeroMode::ctor segfault case upstream to pybind11? (details soon to follow) report AeroMode::ctor segfault case upstream to pybind11 Feb 22, 2024
@dbaston
Copy link

dbaston commented Dec 6, 2024

I came across this during the course of pyOpenSci/software-submission#179 and reported it upstream as pybind/pybind11_json#73.

@slayoo
Copy link
Member Author

slayoo commented Dec 6, 2024

WOW, thanks - both for the report and PR! (pybind/pybind11_json#74)
We'll bump pybind11_json version in PyPartMC right after pybind/pybind11_json#74 is merged, and remove the pytest.skip() from the test.

@slayoo slayoo removed the good first issue Good for newcomers label Dec 6, 2024
@slayoo slayoo changed the title report AeroMode::ctor segfault case upstream to pybind11 bump pybind11_json to fix AeroMode::ctor segfault case (reported and fixed upstream by @dbaston) Dec 6, 2024
slayoo added a commit to slayoo/PyPartMC that referenced this issue Dec 9, 2024
@slayoo slayoo closed this as completed in 92eed8c Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants