bump pybind11_json to 0.2.15 and remove one test skip given a segfaul…

…t was fixed. closes open-atmos#319
slayoo · Dec 9, 2024 · 1d85c54 · 1d85c54
1 parent bd3e22c
commit 1d85c54
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/gitmodules/pybind11_json b/gitmodules/pybind11_json
diff --git a/tests/test_aero_mode.py b/tests/test_aero_mode.py
@@ -291,16 +291,20 @@ def test_ctor_fails_with_nonunique_mass_fracs():
         assert str(exc_info.value) == "mass_frac keys must be unique"
 
     @staticmethod
-    def test_segfault_case():  # TODO #319
-        pytest.skip()
-
+    def test_fixed_segfault_case_on_circular_reference():
+        # arrange
         aero_data = ppmc.AeroData(AERO_DATA_CTOR_ARG_MINIMAL)
         fishy_ctor_arg = copy.deepcopy(AERO_MODE_CTOR_LOG_NORMAL)
         fishy_ctor_arg["test_mode"]["mass_frac"].append(
             fishy_ctor_arg["test_mode"]["mass_frac"]
         )
-        print(fishy_ctor_arg)
-        ppmc.AeroMode(aero_data, fishy_ctor_arg)
+
+        # act
+        with pytest.raises(TypeError) as exc_info:
+            ppmc.AeroMode(aero_data, fishy_ctor_arg)
+
+        # assert
+        assert "incompatible constructor arguments" in str(exc_info.value)
 
     @staticmethod
     @pytest.mark.skipif(platform.machine() == "arm64", reason="TODO #348")
+8 −57		.github/workflows/main.yml
+1 −0		.gitignore
+2 −2		CMakeLists.txt
+5 −14		README.md
+0 −11		dev-environment.yml
+30 −5		include/pybind11_json/pybind11_json.hpp
+3,249 −0		pixi.lock
+56 −0		pixi.toml
+1 −1		test/CMakeLists.txt
+1 −1		test/copyGTest.cmake.in
+2 −2		test/downloadGTest.cmake.in
+19 −0		test/test_pybind11_json.cpp