Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of events on create or delete #112

Conversation

willkutler
Copy link
Contributor

@willkutler willkutler commented Mar 27, 2023

fixes the issue that is causing stolostron/governance-policy-framework-addon#43 to fail

also adds the controller argument to make run - the command does not work without it

Signed-off-by: Will Kutler <wkutler@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, willkutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,willkutler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit da14bdd into open-cluster-management-io:main Mar 27, 2023
willkutler added a commit to stolostron/config-policy-controller that referenced this pull request Mar 27, 2023
willkutler added a commit to stolostron/config-policy-controller that referenced this pull request Mar 27, 2023
willkutler added a commit to stolostron/config-policy-controller that referenced this pull request Mar 27, 2023
…roller#112

Signed-off-by: Will Kutler <wkutler@redhat.com>

fmt

Signed-off-by: Will Kutler <wkutler@redhat.com>
willkutler added a commit to stolostron/config-policy-controller that referenced this pull request Mar 27, 2023
…roller#112

Signed-off-by: Will Kutler <wkutler@redhat.com>

fmt

Signed-off-by: Will Kutler <wkutler@redhat.com>

fmt

Signed-off-by: Will Kutler <wkutler@redhat.com>
openshift-merge-robot pushed a commit to stolostron/config-policy-controller that referenced this pull request Mar 28, 2023
…roller#112

Signed-off-by: Will Kutler <wkutler@redhat.com>

fmt

Signed-off-by: Will Kutler <wkutler@redhat.com>

fmt

Signed-off-by: Will Kutler <wkutler@redhat.com>
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/config-policy-controller-1 that referenced this pull request Apr 3, 2023
…roller#112

Signed-off-by: Will Kutler <wkutler@redhat.com>

fmt

Signed-off-by: Will Kutler <wkutler@redhat.com>

fmt

Signed-off-by: Will Kutler <wkutler@redhat.com>
openshift-merge-robot pushed a commit to stolostron/config-policy-controller that referenced this pull request Apr 4, 2023
…roller#112

Signed-off-by: Will Kutler <wkutler@redhat.com>

fmt

Signed-off-by: Will Kutler <wkutler@redhat.com>

fmt

Signed-off-by: Will Kutler <wkutler@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants