Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-2.7] Manual cherrypick of #35 #43

Closed
wants to merge 2 commits into from
Closed

[release-2.7] Manual cherrypick of #35 #43

wants to merge 2 commits into from

Conversation

willkutler
Copy link

@willkutler willkutler commented Mar 15, 2023 •
edited
Loading

@willkutler
Set parent policy label on template when updating
80b44c7 
Currently, the parent policy label on templates, which is used for open-cluster-management-io#28 , is only set on template creation, which could cause issues with policies that have already been created. This fix verifies the necessary template labels are set when updating the template.

Signed-off-by: Will Kutler <wkutler@redhat.com>
(cherry picked from commit 5a5938b)
@willkutler
Fix cluster namespace label to avoid conflict with propagator
99437d4 
Signed-off-by: Will Kutler <wkutler@redhat.com>

review

Signed-off-by: Will Kutler <wkutler@redhat.com>
(cherry picked from commit a5ccb66)
@openshift-ci
Copy link

openshift-ci bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: willkutler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@willkutler willkutler changed the title Manual cherrypick of #35 Manual cherrypick of https://github.com/open-cluster-management-io/governance-policy-framework-addon/pull/35 Mar 15, 2023
@willkutler willkutler changed the title Manual cherrypick of https://github.com/open-cluster-management-io/governance-policy-framework-addon/pull/35 Manual cherrypick of #35 Mar 15, 2023
@willkutler willkutler changed the title Manual cherrypick of #35 [release-2.7] Manual cherrypick of #35 Mar 15, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

74.1% 74.1% Coverage
0.0% 0.0% Duplication

@willkutler willkutler mentioned this pull request Mar 27, 2023
Merged
@willkutler willkutler closed this Apr 4, 2023
@dhaiducek dhaiducek deleted the manual-cherrypick-35 branch October 16, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@willkutler