Bug: ConfigurationPolicy message for enforce omits objects when multiple namespaces are specified
#116
Conversation
yiraeChristineKim
force-pushed
the
ACM-2604-multi-ns-cherrypick
branch
from
5ed7ddc
to
a054076
Compare
yiraeChristineKim
force-pushed
the
ACM-2604-multi-ns-cherrypick
branch
from
2889e6a
to
47a83e1
Compare
yiraeChristineKim
force-pushed
the
ACM-2604-multi-ns-cherrypick
branch
2 times, most recently
from
d7e709f
to
aed9a71
Compare
yiraeChristineKim
force-pushed
the
ACM-2604-multi-ns-cherrypick
branch
from
aed9a71
to
2bdbd97
Compare
| if statusUpdateNeeded { | ||
| parentStatusUpdateNeeded = true | ||
| } | ||
|
|
||
| if mergeMessageEnforce { | ||
| r.Recorder.Event(&plc, eventNormal, fmt.Sprintf(plcFmtStr, plc.GetName()), |
There was a problem hiding this comment.
Is this correct sending event? is this message will attach to policy history? curious
There was a problem hiding this comment.
I don't think this event sending is necessary? Does it work without this block? It's buried code, but (assuming I'm looking at this right) statusUpdateNeeded propagates down the following function calls, and sendComplianceEvent is the one that finally defines an Event and calls r.Create() to deliver it:
checkRelatedAndUpdateaddForUpdateupdatePolicyStatussendComplianceEvent
yiraeChristineKim
force-pushed
the
ACM-2604-multi-ns-cherrypick
branch
from
2bdbd97
to
987e512
Compare
| if statusUpdateNeeded { | ||
| parentStatusUpdateNeeded = true | ||
| } | ||
|
|
||
| if mergeMessageEnforce { | ||
| r.Recorder.Event(&plc, eventNormal, fmt.Sprintf(plcFmtStr, plc.GetName()), |
There was a problem hiding this comment.
I don't think this event sending is necessary? Does it work without this block? It's buried code, but (assuming I'm looking at this right) statusUpdateNeeded propagates down the following function calls, and sendComplianceEvent is the one that finally defines an Event and calls r.Create() to deliver it:
checkRelatedAndUpdateaddForUpdateupdatePolicyStatussendComplianceEvent
yiraeChristineKim
force-pushed
the
ACM-2604-multi-ns-cherrypick
branch
from
4dd9ba5
to
fe41032
Compare
ConfigurationPolicy message for enforce omits objects when multiple namespaces are specified When set to inform, the full list of objects is shown. But when set to enforce (the first two messages displayed), only the last object message is shown. In multiple namespaces, the message should be merged. Should be fixed like this example: pod [pod1] in namespace test1 found; [pod1] in namespace test2 found as specified, therefore this Object template is compliant Ref: https://issues.redhat.com/browse/ACM-2604 Signed-off-by: Yi Rae Kim <yikim@redhat.com>
yiraeChristineKim
force-pushed
the
ACM-2604-multi-ns-cherrypick
branch
from
fe41032
to
3aab88b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
|
/hold |
|
/unhold |
…ement-io#116) ConfigurationPolicy message for enforce omits objects when multiple namespaces are specified When set to inform, the full list of objects is shown. But when set to enforce (the first two messages displayed), only the last object message is shown. In multiple namespaces, the message should be merged. Should be fixed like this example: pod [pod1] in namespace test1 found; [pod1] in namespace test2 found as specified, therefore this Object template is compliant Ref: https://issues.redhat.com/browse/ACM-2604 Signed-off-by: Yi Rae Kim <yikim@redhat.com> (cherry picked from commit 48f6ec2)
ConfigurationPolicy message for enforce omits objects when multiple namespaces are specified
When set to inform, the full list of objects is shown. But when set to enforce (the first two messages displayed), only the last object message is shown. In multiple namespaces, the message should be merged.
Should be fixed like this example:
pod [pod1] in namespace test1 found; [pod1] in namespace test2 found as specified, therefore this Object template is compliant
Ref: https://issues.redhat.com/browse/ACM-2604