🤖 Sync from open-cluster-management-io/config-policy-controller: #127, #116 #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
This should help keep things a little bit more clear as we add more options. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 8b92ed6)
The recommended settings are 2:30:45 for concurrency:qps:burst. When QPS or Burst are not explicitly set, they will scale based on concurrency. Refs: - https://issues.redhat.com/browse/ACM-4297 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 33bb708)
ConfigurationPolicy message for enforce omits objects when multiple namespaces are specified When set to inform, the full list of objects is shown. But when set to enforce (the first two messages displayed), only the last object message is shown. In multiple namespaces, the message should be merged. Should be fixed like this example: pod [pod1] in namespace test1 found; [pod1] in namespace test2 found as specified, therefore this Object template is compliant Ref: https://issues.redhat.com/browse/ACM-2604 Signed-off-by: Yi Rae Kim <yikim@redhat.com> (cherry picked from commit 48f6ec2)
This was referenced Apr 25, 2023
|
Kudos, SonarCloud Quality Gate passed! |
dhaiducek
approved these changes
Apr 25, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing the following PRs:
ConfigurationPolicymessage forenforceomits objects when multiple namespaces are specified open-cluster-management-io/config-policy-controller#116This replaces #482.
Closes #484
Closes #485