QPS config #127
QPS config #127
Conversation
This should help keep things a little bit more clear as we add more options. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
| flags.Float32Var( | ||
| &opts.clientQPS, | ||
| "client-max-qps", | ||
| 30, // 15 * concurrency is recommended |
There was a problem hiding this comment.
I was thinking that if the QPS is not explicitly set, then we can do 15 * evaluationConcurrency rather than rely on the user to know they should also adjust QPS.
There was a problem hiding this comment.
I was planning on doing that kind of configuration in the addon-controller, but I can do it here.
| @@ -176,6 +153,9 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| cfg.Burst = int(opts.clientBurst) | |||
| cfg.QPS = opts.clientQPS | |||
There was a problem hiding this comment.
Where cfg.QPS used?
There was a problem hiding this comment.
cfg gets assigned to targetK8sConfig which then gets used to create Kubernetes API client instances for ConfigurationPolicyReconciler. It's also used by the controller-runtime manager to create a Kubernetes API client.
The recommended settings are 2:30:45 for concurrency:qps:burst. When QPS or Burst are not explicitly set, they will scale based on concurrency. Refs: - https://issues.redhat.com/browse/ACM-4297 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The recommended settings are like 2:30:45 for concurrency:qps:burst. When QPS or Burst are not explicitly set, they will scale based on concurrency.
Refs: