Clear compliancyDetails on template error #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaiducek
force-pushed
the
5512-status-length-2
branch
8 times, most recently
from
0b2d463
to
173f9e6
Compare
- Replace `Eventually` with `EventuallyWithOffset` - Use native Gomega assertions instead of custom assertions Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
5512-status-length-2
branch
2 times, most recently
from
74c9b86
to
fa35fc4
Compare
- Clear compliancyDetails on policy-wide errors - Reduce the length of the array if the number of object-templates is lower ref: https://issues.redhat.com/browse/ACM-5512 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
5512-status-length-2
branch
from
fa35fc4
to
9d64024
Compare
|
Sorry for the churn here (I definitely should have made it a draft first!). CI is passing, and this is ready for review. |
JustinKuli
approved these changes
May 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adjusts the CompliancyDetails array for the number of object-templates.
ref: https://issues.redhat.com/browse/ACM-5512