Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/config-policy-controller: #133 #498

Merged
merged 2 commits into from
May 18, 2023

Conversation

magic-mirror-bot[bot]
Copy link

@magic-mirror-bot magic-mirror-bot bot commented May 18, 2023

- Replace `Eventually` with `EventuallyWithOffset`
- Use native Gomega assertions instead of custom assertions

Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
(cherry picked from commit 3e915f5)
- Clear compliancyDetails on policy-wide errors
- Reduce the length of the array if the number of
  object-templates is lower

ref: https://issues.redhat.com/browse/ACM-5512
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
(cherry picked from commit 9b8a98f)
@dhaiducek
Copy link
Contributor

/override "KinD / Tests (latest, false, hosted)"

@openshift-ci
Copy link

openshift-ci bot commented May 18, 2023

@dhaiducek: Overrode contexts on behalf of dhaiducek: KinD / Tests (latest, false, hosted)

In response to this:

/override "KinD / Tests (latest, false, hosted)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarcloud
Copy link

sonarcloud bot commented May 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.7% 86.7% Coverage
0.0% 0.0% Duplication

@openshift-ci
Copy link

openshift-ci bot commented May 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, magic-mirror-bot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 2073d16 into main May 18, 2023
@openshift-merge-robot openshift-merge-robot deleted the magic-mirror-main-1684417907739 branch May 18, 2023 18:19
@mprahl
Copy link
Contributor

mprahl commented Jun 22, 2023

/cherry-pick release-2.7

@openshift-cherrypick-robot

@mprahl: #498 failed to apply on top of branch "release-2.7":

Applying: Refactor test utils
Using index info to reconstruct a base tree...
M	test/utils/utils.go
Falling back to patching base and 3-way merge...
Auto-merging test/utils/utils.go
CONFLICT (content): Merge conflict in test/utils/utils.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Refactor test utils
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-2.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😿 Failed to sync the upstream PRs: #133
4 participants