Check all items in lists #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing test used both `mergeArrays` and `checkListsMatch`. Those were split, to make it a bit more clear what is being asserted. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
dhaiducek
approved these changes
Oct 12, 2023
|
/hold |
|
I'm not sure that's the right Jira issue... |
Refs: - https://issues.redhat.com/browse/ACM-7889 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Some of the logic in the `checkListsMatch` function does not require the copies of the inputs to be created or sorted. This does those checks first, potentially skipping the unnecessary work. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
From some debugging for an issue, it became apparent that this function was not actually being called in situations where it might have been expected... Basically the switch case that might have called it is not reachable. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
7899-list-checking
branch
from
ceb4264
to
849d136
Compare
|
Good catch, I meant to write 7889, not 7899 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit 325af48
into
open-cluster-management-io:main
4 checks passed
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACM-7899https://issues.redhat.com/browse/ACM-7889