Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all items in lists #164

Merged

Commits on Oct 10, 2023

  1. Reorganize unit tests for list merging/matching

    The existing test used both `mergeArrays` and `checkListsMatch`. Those
    were split, to make it a bit more clear what is being asserted.
    
    Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    JustinKuli committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a461a7a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Fix bug where only one list item was being checked

    Refs:
     - https://issues.redhat.com/browse/ACM-7889
    
    Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    JustinKuli committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    bfe013b View commit details
    Browse the repository at this point in the history
  2. Refactor some optimizations

    Some of the logic in the `checkListsMatch` function does not require the
    copies of the inputs to be created or sorted. This does those checks
    first, potentially skipping the unnecessary work.
    
    Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    JustinKuli committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    26ba3bd View commit details
    Browse the repository at this point in the history
  3. Remove checkFieldsWithSort

    From some debugging for an issue, it became apparent that this function
    was not actually being called in situations where it might have been
    expected... Basically the switch case that might have called it is not
    reachable.
    
    Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    JustinKuli committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    849d136 View commit details
    Browse the repository at this point in the history