Handle values omitted from the API server in arrays of objects #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the example of a Pod definition in a Deployment, you could set `stdin: false` and `tty: false` for the container in a ConfigurationPolicy, but the API server would omit them from the return value. This would lead to the merged map and existing map to have a different length, and causing the comparison to end early. This was wrong in this case since a missing boolean should be treated the same as `false` set in the ConfigurationPolicy. Relates: https://issues.redhat.com/browse/ACM-8391 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
yiraeChristineKim
approved these changes
Nov 2, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
merged commit e88b230
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example of a Pod definition in a Deployment, you could set
stdin: falseandtty: falsefor the container in a ConfigurationPolicy, but the API server would omit them from the return value. This would lead to the merged map and existing map to have a different length, and causing the comparison to end early. This was wrong in this case since a missing boolean should be treated the same asfalseset in the ConfigurationPolicy.Relates:
https://issues.redhat.com/browse/ACM-8391