-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🤖 Sync from open-cluster-management-io/config-policy-controller: #172 #622
Conversation
In the example of a Pod definition in a Deployment, you could set `stdin: false` and `tty: false` for the container in a ConfigurationPolicy, but the API server would omit them from the return value. This would lead to the merged map and existing map to have a different length, and causing the comparison to end early. This was wrong in this case since a missing boolean should be treated the same as `false` set in the ConfigurationPolicy. Relates: https://issues.redhat.com/browse/ACM-8391 Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit e88b230)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: magic-mirror-bot[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Kudos, SonarCloud Quality Gate passed! |
/cherry-pick release-2.9 |
/cherry-pick release-2.8 |
/cherry-pick release-2.7 |
@mprahl: new pull request created: #623 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mprahl: #622 failed to apply on top of branch "release-2.8":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@mprahl: #622 failed to apply on top of branch "release-2.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing the following PRs: