Fix a bug related to unnamed objects #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where an object-template included an unnamed object and only one object was returned, it went into the typical `handleSingleObj` flow but marked `exists` as true without setting `existingObj` in the input to `handleSingleObj`. There was an assumption that `existingObj` would always be set if `exists` was set. Commit ffc115c made this panic because `GetUID` was being called on a nil `existingObj`. Prior to this, it seems it would just erroneously say it was compliant without checking it. Relates: https://issues.redhat.com/browse/ACM-8731 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
yiraeChristineKim
approved these changes
Nov 21, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mprahl, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit a901475
into
open-cluster-management-io:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where an object-template included an unnamed object and only one object was returned, it went into the typical
handleSingleObjflow but markedexistsas true without settingexistingObjin the input tohandleSingleObj. There was an assumption thatexistingObjwould always be set ifexistswas set.Commit ffc115c made this panic because
GetUIDwas being called on a nilexistingObj. Prior to this, it seems it would just erroneously say it was compliant without checking it.Relates:
https://issues.redhat.com/browse/ACM-8731