🤖 Sync from open-cluster-management-io/config-policy-controller: #177, #178 #646
Conversation
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> (cherry picked from commit 5a2004d)
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com> (cherry picked from commit 02eee99)
In the case where an object-template included an unnamed object and only one object was returned, it went into the typical `handleSingleObj` flow but marked `exists` as true without setting `existingObj` in the input to `handleSingleObj`. There was an assumption that `existingObj` would always be set if `exists` was set. Commit ffc115c made this panic because `GetUID` was being called on a nil `existingObj`. Prior to this, it seems it would just erroneously say it was compliant without checking it. Relates: https://issues.redhat.com/browse/ACM-8731 Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit a901475)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: magic-mirror-bot[bot], mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Kudos, SonarCloud Quality Gate passed! |
|
/cherry-pick release-2.9 |
|
/cherry-pick release-2.8 |
|
@mprahl: new pull request created: #652 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mprahl: new pull request created: #653 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Syncing the following PRs:
Closes #647