Stop the NS controller manager during hosted mode uninstalls #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mprahl
changed the title
mprahl
force-pushed
the
uninstall-cluster-down
branch
4 times, most recently
from
eb3b694
to
133cca6
Compare
In hosted mode, there is no guarantee that the managed cluster's API server is available when this controller is being uninstalled. In this case, we can't have any controller-runtime managers connecting to the managed cluster's API server during that time. If there are, the controller can restart without completing the required uninstall cleanup and then can't properly restart since the manager cannot be instantiated. Relates: https://issues.redhat.com/browse/ACM-8826 Signed-off-by: mprahl <mprahl@users.noreply.github.com>
mprahl
force-pushed
the
uninstall-cluster-down
branch
from
133cca6
to
5586260
Compare
mprahl
changed the title
JustinKuli
approved these changes
Dec 1, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JustinKuli, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f3029de
into
open-cluster-management-io:main
4 checks passed
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hosted mode, there is no guarantee that the managed cluster's API server is available when this controller is being uninstalled. In this case, we can't have any controller-runtime managers connecting to the managed cluster's API server during that time. If there are, the controller can restart without completing the required uninstall cleanup and then can't properly restart since the manager cannot be instantiated.
Relates:
https://issues.redhat.com/browse/ACM-8826