Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/config-policy-controller: #180 #656

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

magic-mirror-bot[bot]
Copy link

@magic-mirror-bot magic-mirror-bot bot commented Dec 1, 2023

In hosted mode, there is no guarantee that the managed cluster's API
server is available when this controller is being uninstalled. In this
case, we can't have any controller-runtime managers connecting to the
managed cluster's API server during that time. If there are, the
controller can restart without completing the required uninstall cleanup
and then can't properly restart since the manager cannot be
instantiated.

Relates:
https://issues.redhat.com/browse/ACM-8826

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
(cherry picked from commit f3029de)
Copy link

openshift-ci bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign mprahl for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

81.6% 81.6% Coverage
0.0% 0.0% Duplication

@mprahl mprahl merged commit 2e9b61c into main Dec 1, 2023
14 of 15 checks passed
@mprahl mprahl deleted the magic-mirror-main-1701443175151 branch December 1, 2023 16:10
@mprahl
Copy link
Contributor

mprahl commented Dec 1, 2023

/cherry-pick release-2.9

@mprahl
Copy link
Contributor

mprahl commented Dec 1, 2023

/cherry-pick release-2.8

@openshift-cherrypick-robot

@mprahl: new pull request created: #658

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@mprahl: new pull request created: #659

In response to this:

/cherry-pick release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😿 Failed to sync the upstream PRs: #180
2 participants