9283 review followup #194
Merged
9283 review followup #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loop variables are re-used in different iterations, which means taking the address of one can lead to unexpected results. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
This might prevent conditions of the same type from being duplicated in the status. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
There was already one like this when the OperatorGroup was not being specified in the OperatorPolicy, but this helps keep things complete. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
9283-review-followup
branch
from
421bed9
to
8abbef1
Compare
dhaiducek
approved these changes
Feb 1, 2024
| @@ -96,6 +96,8 @@ type OperatorPolicyStatus struct { | |||
| // Most recent compliance state of the policy | |||
| ComplianceState policyv1.ComplianceState `json:"compliant,omitempty"` | |||
| // Historic details on the condition of the policy | |||
| // +listType=map | |||
| // +listMapKey=type | |||
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 3da5031
into
open-cluster-management-io:main
4 checks passed
This was referenced Feb 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves some final comments from the previous PR review, as well as an issue
gosecnoticed.