Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

9283 review followup #194

Merged
merged 3 commits into from
Feb 1, 2024
Merged

9283 review followup #194

merged 3 commits into from
Feb 1, 2024

Commits on Jan 31, 2024

  1. Fix issue gosec-scan noticed with loop addresses 

    Loop variables are re-used in different iterations, which means taking
the address of one can lead to unexpected results.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    @JustinKuli
    JustinKuli committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    a0fbbff View commit details
    Browse the repository at this point in the history

  2. Use listType=map for OperatorPolicy conditions 

    This might prevent conditions of the same type from being duplicated
in the status.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    @JustinKuli
    JustinKuli committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    da47707 View commit details
    Browse the repository at this point in the history

  3. Add additional test for TooManyOperatorGroups 

    There was already one like this when the OperatorGroup was not being
specified in the OperatorPolicy, but this helps keep things complete.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    @JustinKuli
    JustinKuli committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    8abbef1 View commit details
    Browse the repository at this point in the history