Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upgradeApproval field to OperatorPolicy #249

Commits on May 22, 2024

  1. Add upgradeApproval field to OperatorPolicy

    Breaking change: setting `InstallPlanApproval` on the subscription is
    invalid, and will result in a noncompliant policy that does not perform
    any other actions. Previously, *not* setting that field was invalid.
    
    Being able to set `InstallPlanApproval` in the policy was somewhat
    confusing, because the controller would override the supplied value in
    many cases, in order to have control over which upgrades would be
    approved. Additionally, there was a desire to separate the approval for
    the initial installation from the approval for later upgrades.
    
    The new field addresses these concerns. Initial installs will be
    approved whenever the policy is enforced (as long as it matches the
    policy's specified allowed versions), and upgrades will only be approved
    when `upgradeApproval` is set to Automatic.
    
    Refs:
     - https://issues.redhat.com/browse/ACM-11268
    
    Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
    JustinKuli committed May 22, 2024
    Configuration menu
    Copy the full SHA
    2390970 View commit details
    Browse the repository at this point in the history