Add upgradeApproval field to OperatorPolicy #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gparvin
reviewed
May 21, 2024
gparvin
reviewed
May 21, 2024
deploy/crds/kustomize_operatorpolicy/policy.open-cluster-management.io_operatorpolicies.yaml
Outdated
Show resolved
Hide resolved
gparvin
reviewed
May 21, 2024
deploy/crds/policy.open-cluster-management.io_operatorpolicies.yaml
Outdated
Show resolved
Hide resolved
|
/hold for Gus comments |
Breaking change: setting `InstallPlanApproval` on the subscription is invalid, and will result in a noncompliant policy that does not perform any other actions. Previously, *not* setting that field was invalid. Being able to set `InstallPlanApproval` in the policy was somewhat confusing, because the controller would override the supplied value in many cases, in order to have control over which upgrades would be approved. Additionally, there was a desire to separate the approval for the initial installation from the approval for later upgrades. The new field addresses these concerns. Initial installs will be approved whenever the policy is enforced (as long as it matches the policy's specified allowed versions), and upgrades will only be approved when `upgradeApproval` is set to Automatic. Refs: - https://issues.redhat.com/browse/ACM-11268 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
JustinKuli
force-pushed
the
11268-upgrade-approval-field
branch
from
aa46c6c
to
2390970
Compare
gparvin
approved these changes
May 23, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gparvin, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit 5b60de6
into
open-cluster-management-io:main
9 checks passed
JustinKuli
added a commit
to stolostron/governance-policy-framework
that referenced
this pull request
May 29, 2024
Per a recent change in the controller, it is now invalid to specify installPlanApproval in an OperatorPolicy, and it is necessary to specify upgradeApproval. Refs: - open-cluster-management-io/config-policy-controller#249 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
openshift-merge-bot bot
pushed a commit
to stolostron/governance-policy-framework
that referenced
this pull request
May 29, 2024
Per a recent change in the controller, it is now invalid to specify installPlanApproval in an OperatorPolicy, and it is necessary to specify upgradeApproval. Refs: - open-cluster-management-io/config-policy-controller#249 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change: setting
InstallPlanApprovalon the subscription is invalid, and will result in a noncompliant policy that does not perform any other actions. Previously, not setting that field was invalid.Being able to set
InstallPlanApprovalin the policy was somewhat confusing, because the controller would override the supplied value in many cases, in order to have control over which upgrades would be approved. Additionally, there was a desire to separate the approval for the initial installation from the approval for later upgrades.The new field addresses these concerns. Initial installs will be approved whenever the policy is enforced (as long as it matches the policy's specified allowed versions), and upgrades will only be approved when
upgradeApprovalis set to Automatic.Refs: