🤖 Sync from open-cluster-management-io/config-policy-controller: #248, #250, #251, #249, #254 #875
Conversation
![magic-mirror-bot[bot]](https://avatars.githubusercontent.com/u/60207193?s=60&v=4){kind=small}
Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 8a93c02)
This provides more context as to why it may be unsafe to enable it. Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 6771aef)
Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 8f2947e)
Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 65d1a80)
Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 42358ff)
This ensures the OperatorPolicy is deleted before the operator is deleted. Hopefully this will address some of the test flakes. Signed-off-by: mprahl <mprahl@users.noreply.github.com> (cherry picked from commit 23216e2)
Breaking change: setting `InstallPlanApproval` on the subscription is invalid, and will result in a noncompliant policy that does not perform any other actions. Previously, *not* setting that field was invalid. Being able to set `InstallPlanApproval` in the policy was somewhat confusing, because the controller would override the supplied value in many cases, in order to have control over which upgrades would be approved. Additionally, there was a desire to separate the approval for the initial installation from the approval for later upgrades. The new field addresses these concerns. Initial installs will be approved whenever the policy is enforced (as long as it matches the policy's specified allowed versions), and upgrades will only be approved when `upgradeApproval` is set to Automatic. Refs: - https://issues.redhat.com/browse/ACM-11268 Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com> (cherry picked from commit 5b60de6)
Signed-off-by: GitHub <noreply@github.com> (cherry picked from commit 622c8e4)
|
@magic-mirror-bot[bot]: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: magic-mirror-bot[bot], mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Forcing a merge to workaround the image not building correctly. |
Syncing the following PRs:
Closes #876