Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the hosting test namespace before the hosted test namespace #251

Merged

Conversation

mprahl
Copy link
Member

@mprahl mprahl commented May 22, 2024

This ensures the OperatorPolicy is deleted before the operator is deleted. Hopefully this will address some of the test flakes.

The first commit includes a launch.json configuration for hosted mode.

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
This ensures the OperatorPolicy is deleted before the operator is
deleted. Hopefully this will address some of the test flakes.

Signed-off-by: mprahl <mprahl@users.noreply.github.com>
Copy link
Member

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth a try at least 😆

Copy link

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, mprahl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mprahl
Copy link
Member Author

mprahl commented May 23, 2024

@JustinKuli 1 of the 2 failed but I'll give this a retry since I think this change is still valuable but not the fix I was hoping for.

@openshift-merge-bot openshift-merge-bot bot merged commit 23216e2 into open-cluster-management-io:main May 23, 2024
9 checks passed
@dhaiducek
Copy link
Member

Things seem to be slower on older Kubernetes--the E2E tests seem to fail more frequently on the minimum version. I'm wondering: Should we extend the default timeout just for the older version? Or bump the minimum version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants