Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OperatorPolicy tests for upgradeApproval #817

Merged
merged 1 commit into from
May 29, 2024

Conversation

JustinKuli
Copy link
Contributor

Per a recent change in the controller, it is now invalid to specify installPlanApproval in an OperatorPolicy, and it is necessary to specify upgradeApproval.

Refs:

Per a recent change in the controller, it is now invalid to specify
installPlanApproval in an OperatorPolicy, and it is necessary to specify
upgradeApproval.

Refs:
 - open-cluster-management-io/config-policy-controller#249

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Copy link

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JustinKuli
Copy link
Contributor Author

/test ?

Copy link

openshift-ci bot commented May 29, 2024

@JustinKuli: The following commands are available to trigger required jobs:

  • /test images
  • /test pr-image-mirror
  • /test test-e2e-grc-framework

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-stolostron-governance-policy-framework-main-images
  • pull-ci-stolostron-governance-policy-framework-main-pr-image-mirror

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JustinKuli
Copy link
Contributor Author

/test test-e2e-grc-framework

@JustinKuli
Copy link
Contributor Author

/retest

@JustinKuli
Copy link
Contributor Author

GRC: [P1][Sev1][policy-grc] Test the policy-rolebinding policy [It] stable/policy-rolebinding should be created on the Hub [policy-collection, stable]
/go/src/github.com/stolostron/governance-policy-framework/test/integration/policy_rolebinding_test.go:32

  [FAILED] Unexpected error:
      <*url.Error | 0xc000832a80>: 
      Post "https://api.policy-grc-cp-prow-pcn4d.dev08.red-chesterfield.com:6443/api/v1/namespaces": read tcp 10.129.182.180:35192->54.161.158.148:6443: read: connection reset by peer

@openshift-merge-bot openshift-merge-bot bot merged commit c128d83 into main May 29, 2024
10 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the fix-installplanapproval-oppol branch May 29, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants