More dryrun improvements #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the main package was at `./cmd`, when installed via `go install` the tool would just be called `cmd`. Now it will be installed as `dryrun` (although the path is very slightly different). Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
Adds a launch.json configuration for running/debugging the cli. Also more correctly silences the usage doc: if inputs are incorrect, it is helpful to print the doc. Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
dhaiducek
approved these changes
Oct 3, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ae2abbc
into
open-cluster-management-io:main
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "big" change here is the path of the cli, so that it can be better installed via
go install. It will also now print the usage doc if the user inputs are incorrect.