Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Sync from open-cluster-management-io/config-policy-controller: #302 #1048

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

magic-mirror-bot[bot]
Copy link

@magic-mirror-bot magic-mirror-bot bot commented Oct 3, 2024

Because the main package was at `./cmd`, when installed via `go install`
the tool would just be called `cmd`. Now it will be installed as
`dryrun` (although the path is very slightly different).

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit 489b1a3471511af434d951e79cd4bc2cdfc40f29)
Adds a launch.json configuration for running/debugging the cli. Also
more correctly silences the usage doc: if inputs are incorrect, it is
helpful to print the doc.

Signed-off-by: Justin Kulikauskas <jkulikau@redhat.com>
(cherry picked from commit ae2abbc4602263e8902ba80272586d2b0c6c9d51)
Copy link

sonarcloud bot commented Oct 3, 2024

Copy link
Contributor

@JustinKuli JustinKuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obama-awards-obama-a-medal

Copy link

openshift-ci bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JustinKuli, magic-mirror-bot[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dbd5ae3 into main Oct 4, 2024
18 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the magic-mirror-main-1727973132224 branch October 4, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😿 Failed to sync the upstream PRs: #302
1 participant