Provision local development environment with vagrant #9
Conversation
|
Not sure why the integration test failed, looks like scp was expecting a password. |
|
@omarkhan Thank you for this! I'll have a look at it over the week-end. Given that this partially duplicates #3 would it make sense for you and @brousch to collaborate, and consolidate your submissions on a single PR? I haven't looked at the current PR yet, so not sure if that makes sense, but I'd like to know what you think about it. Note that this isn't a requirement or part of the recruitment process - the additional contribution and/or collaboration is a bonus, but it won't be held against you if you don't do it. |
|
Also - for the build, that's because the commits come from a fork, so CircleCI doesn't load the auth. I've pushed the branch to the main repo to trigger a rebuild with the right auth. |
|
@brousch I had already pretty much finished this by the time I saw your changes, so I made a separate pull request. I had a quick look through yours - it looks like you made a few changes to make it easier for people running windows. I'm not a windows user so I don't really know what that entails, what extra things do you have to do to get it working? |
|
For Windows, I had to assume that .py files were not executable (for example, always use |
|
Thanks. This uses postgres instead of sqlite so that shouldn't be an issue. For the executable issues, will pulling in your Makefile changes be enough, or is there more to it? Would you be able to test this on windows? |
|
I think we should use your Vagrantfile PR and then I could make a separate PR for the Makefile changes so I can test it properly on Windows. |
|
Good idea 👍 |
| configured. To run them, create a `.env.test` file - your development environment is likely a good | ||
| starting point: | ||
| Note that the integration tests aren't run by default, as they require a working | ||
| OpenStack cluster configured. To run them, create a `.env.integration` file - |
There was a problem hiding this comment.
@omarkhan Good catch - thanks!
In case we ever want to run other apps inside the vm
|
@omarkhan Thank you again for this - works like a charm here. 👍 I'll merge if the integration tests pass. |
Provision local development environment with vagrant
# This is the 1st commit message: Re-writing circle.yml to store code coverage in CircleCI's workspace and collect them afterwards. Test run parallelization is used with environment variables instead of using custom test runner. # This is the commit message #2: Update Makefile message. # This is the commit message #3: Remove cov.html from cov.combine. # This is the commit message #4: Stop running all tests in all containers # This is the commit message #5: Cleanup # This is the commit message #6: Experiment with different IDs for each coverage report # This is the commit message #7: Gathering raw coverage from all steps # This is the commit message #8: Always copy coverage and log message when not found # This is the commit message #9: Log copying raw coverage files for debugging
This pull request is similar to #3, with the following differences:
~/.bashrc